]> git.hungrycats.org Git - linux/commit
dm era: fix NULL pointer dereference in metadata_open()
authorCao Guanghui <caoguanghui@kylinos.cn>
Wed, 17 Jun 2026 06:00:52 +0000 (14:00 +0800)
committerMikulas Patocka <mpatocka@redhat.com>
Wed, 8 Jul 2026 20:33:35 +0000 (22:33 +0200)
commit9ae672606c17891d90b282e3490b817620549599
tree22421283491c3b846d0192042853fce657d2f0cb
parent981ccd97f7153d310dfa92a534525bbaf46752c2
dm era: fix NULL pointer dereference in metadata_open()

metadata_open() returns NULL when kzalloc_obj() fails, but the
caller era_ctr() only checks IS_ERR(md).  Since IS_ERR(NULL)
returns false, the NULL pointer is treated as a valid result
and later assigned to era->md, leading to a NULL pointer
dereference when the metadata is accessed.

Fix this by returning ERR_PTR(-ENOMEM) on allocation failure,
consistent with dm-cache-metadata.c, dm-thin-metadata.c, and
dm-clone-metadata.c which all use ERR_PTR(-ENOMEM) for the
same pattern.

Fixes: eec40579d848 ("dm: add era target")
Signed-off-by: Cao Guanghui <caoguanghui@kylinos.cn>
Reviewed-by: Su Yue <glass.su@suse.com>
Reviewed-by: Ming-Hung Tsai <mtsai@redhat.com>
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
drivers/md/dm-era-target.c