]> git.hungrycats.org Git - linux/commit
pptp: fix stack info leak in pptp_getname()
authorMathias Krause <minipli@googlemail.com>
Wed, 19 Nov 2014 17:05:26 +0000 (18:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 6 Dec 2014 23:57:17 +0000 (15:57 -0800)
commit9c3e21500a2def0b02ff772f3eb9c23629a1424a
tree112c49e39062cdab49f2a6e6023b6128afd19111
parentb9cd8078ff5e80f31a554cae12df0686e12f9edc
pptp: fix stack info leak in pptp_getname()

[ Upstream commit a5f6fc28d6e6cc379c6839f21820e62262419584 ]

pptp_getname() only partially initializes the stack variable sa,
particularly only fills the pptp part of the sa_addr union. The code
thereby discloses 16 bytes of kernel stack memory via getsockname().

Fix this by memset(0)'ing the union before.

Cc: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ppp/pptp.c