]> git.hungrycats.org Git - linux/commit
btrfs: handle zero num_stripes in btrfs_chunk_item_size()
authorCheng Yongkang <teel4res@gmail.com>
Sun, 1 Nov 2026 07:14:44 +0000 (00:14 -0700)
committerQu Wenruo <wqu@suse.com>
Sun, 1 Nov 2026 08:34:58 +0000 (19:04 +1030)
commita919d4a3e8312a6081beddada0cb2dfc91fa7c66
tree7bc93e8096b21565c0648f5a9cfdb2f316e8a8dc
parentda7cc40ba243b566a7d6281ef356da58196fa669
btrfs: handle zero num_stripes in btrfs_chunk_item_size()

validate_sys_chunk_array() calls btrfs_chunk_item_size() with the
on-disk num_stripes before btrfs_check_chunk_valid() has checked the
chunk. With CONFIG_BTRFS_ASSERT=y, a zero-stripe system chunk trips
ASSERT(num_stripes) instead of being rejected:

  assertion failed: num_stripes, in fs/btrfs/volumes.h:714
  kernel BUG at fs/btrfs/volumes.h:714!
  RIP: 0010:btrfs_validate_super+0x3ce7/0x4210
  Call Trace:
   open_ctree
   btrfs_get_tree
   vfs_get_tree
   do_new_mount

Drop the assertion and compute the size as the chunk header plus
num_stripes stripes. The size is unchanged for num_stripes > 0, and a
zero-stripe chunk now reaches btrfs_check_chunk_valid(), which rejects
it, so the mount fails with -EUCLEAN.

Suggested-by: Qu Wenruo <wqu@suse.com>
Link: https://lore.kernel.org/linux-btrfs/d2ee0cc1-674e-4447-88da-d346122a43a4@suse.com/
Fixes: 2a9bb78cfd36 ("btrfs: validate system chunk array at btrfs_validate_super()")
Signed-off-by: Cheng Yongkang <teel4res@gmail.com>
[ Slightly rework the commit message. ]
Signed-off-by: Qu Wenruo <wqu@suse.com>
fs/btrfs/volumes.h