]> git.hungrycats.org Git - linux/commit
gpio: pca953x: Fix corruption of other gpios in set_multiple.
authorPhil Reid <preid@electromag.com.au>
Tue, 8 Nov 2016 06:00:45 +0000 (14:00 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 26 Nov 2016 08:56:59 +0000 (09:56 +0100)
commita9a0027757f8c317f1d7334c095bde96b4a0f84c
tree03479227ba3c109ffe65c830e2049499987100ec
parent88fce76cf59055ddf97667001dbd26577b8760e0
gpio: pca953x: Fix corruption of other gpios in set_multiple.

commit 53f8d322234649b4d6f1515b20c127a577efd164 upstream.

gpiod_set_array_value_complex does not clear the bits field.
Therefore when the drivers set_multiple funciton is called bits outside
the mask are undefined and can be either set or not. So bank_val needs
to be masked with bank_mask before or with the reg_val cache.

Fixes: b4818afeacbd ("gpio: pca953x: Add set_multiple to allow multiple")
Signed-off-by: Phil Reid <preid@electromag.com.au>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpio-pca953x.c