]> git.hungrycats.org Git - linux/commit
usb: musb: Fix musb_gadget.c rxstate overflow bug
authorRobin Guo <guoweibin@inspur.com>
Tue, 6 Sep 2022 02:21:19 +0000 (10:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:26 +0000 (09:58 +0200)
commita9ccd2ab1becf5dcb6d57e9fcd981f5eaa606c96
treeb8bd363ac17a40dae3e848ff04baa60f16892464
parenta40ad475236022f3432880e3091c380e46e71a71
usb: musb: Fix musb_gadget.c rxstate overflow bug

[ Upstream commit eea4c860c3b366369eff0489d94ee4f0571d467d ]

The usb function device call musb_gadget_queue() adds the passed
request to musb_ep::req_list,If the (request->length > musb_ep->packet_sz)
and (is_buffer_mapped(req) return false),the rxstate() will copy all data
in fifo to request->buf which may cause request->buf out of bounds.

Fix it by add the length check :
fifocnt = min_t(unsigned, request->length - request->actual, fifocnt);

Signed-off-by: Robin Guo <guoweibin@inspur.com>
Link: https://lore.kernel.org/r/20220906102119.1b071d07a8391ff115e6d1ef@inspur.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/musb/musb_gadget.c