]> git.hungrycats.org Git - linux/commit
btrfs: zoned: fix possible UAF in wait_eb_writebacks()
authorJohannes Thumshirn <johannes.thumshirn@wdc.com>
Wed, 9 Sep 2026 09:45:34 +0000 (11:45 +0200)
committerDavid Sterba <dsterba@suse.com>
Fri, 30 Oct 2026 20:36:17 +0000 (21:36 +0100)
commitaa5b989352093aeebb4ad85ca9fc94667cf6f7ef
tree608b58b5d2f1582076be260c784d1846928088fe
parent92858f83df7b41e1b20d65506e08e6d434004791
btrfs: zoned: fix possible UAF in wait_eb_writebacks()

wait_eb_writebacks() iterates the fs_info->buffer_tree xarray and waits
for the writeback of these extent-buffers. Waiting for writeback needs
to be done without the rcu_read_lock() held (because it can sleep) and
thus the loop drops the rcu_read_lock() before calling into
wait_on_extent_buffer_writeback(). But extent_buffers are freed through
RCU, so if btrfs_release_extent_buffer_rcu() is scheduled while we're
still waiting on the writeback, the extent_buffer will be freed causing
a use-after-free.

Similar to what is done in find_extent_buffer_nolock(), get a reference
to the extent_buffer before calling into
wait_on_extent_buffer_writeback() so a successful writeback does not
free the extent_buffer while we still have a reference to it.

Fixes: 2dd7e7bc0282 ("btrfs: zoned: wait for extent buffer IOs before finishing a zone")
Reviewed-by: Daniel Vacek <neelx@suse.com>
Signed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/zoned.c