]> git.hungrycats.org Git - linux/commit
ALSA: firewire-lib: fix return value on fail in amdtp_tscm_init()
authorMurad Masimov <m.masimov@maxima.ru>
Fri, 1 Nov 2024 18:55:13 +0000 (21:55 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 17 Nov 2024 13:59:36 +0000 (14:59 +0100)
commitac40b9dff2740010ae3fbe298dc10fdcd089b544
tree601bfd6158948b6c59c6164796c317d2d5991c52
parentc1eba9f0e235aa119982f321fa1552149029e51d
ALSA: firewire-lib: fix return value on fail in amdtp_tscm_init()

[ Upstream commit 8abbf1f01d6a2ef9f911f793e30f7382154b5a3a ]

If amdtp_stream_init() fails in amdtp_tscm_init(), the latter returns zero,
though it's supposed to return error code, which is checked inside
init_stream() in file tascam-stream.c.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 47faeea25ef3 ("ALSA: firewire-tascam: add data block processing layer")
Signed-off-by: Murad Masimov <m.masimov@maxima.ru>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20241101185517.1819-1-m.masimov@maxima.ru
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/firewire/tascam/amdtp-tascam.c