]> git.hungrycats.org Git - linux/commit
bcma: fix buffer size caused crash in bcma_core_mips_print_irq()
authorRafał Miłecki <rafal@milecki.pl>
Tue, 8 May 2018 09:31:04 +0000 (11:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 06:17:17 +0000 (08:17 +0200)
commitb0ea08e1bd67af984e4de51f05c973528cd0f7fb
tree2d1707dac21cbba47fab92ba23d4d98c1856b04f
parent98d02fd4618c48d75589820e8fc39e60c3d3728e
bcma: fix buffer size caused crash in bcma_core_mips_print_irq()

commit 361de091a4b97aa9081d304d742f80d486ab7125 upstream.

Used buffer wasn't big enough to hold whole strings. Example output of
this function is:
[    0.180892] bcma: bus0: core 0x0800, irq: 2(S)* 3  4  5  6  D  I
[    0.180948] bcma: bus0: core 0x0812, irq: 2(S)  3* 4  5  6  D  I
[    0.180998] bcma: bus0: core 0x082d, irq: 2(S)  3  4* 5  6  D  I
[    0.181046] bcma: bus0: core 0x082c, irq: 2(S)  3  4  5  6  D  I*
which means we need to store up to 24 chars.

Fixes: 758f7e06063a8 ("bcma: Use bcma_debug and not pr_cont in MIPS driver")
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/bcma/driver_mips.c