]> git.hungrycats.org Git - linux/commit
packet: packet_getname_spkt: make sure string is always 0-terminated
authorDaniel Borkmann <dborkman@redhat.com>
Wed, 12 Jun 2013 14:02:27 +0000 (16:02 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jun 2013 17:34:33 +0000 (10:34 -0700)
commitb4d45a2af9c9ca5c14e00375366125e7c31d5293
tree3baa2de8d222632222df024f1e162204c4f9360c
parentbba0c7f5421c40314ef48be4a7540efa76166dcd
packet: packet_getname_spkt: make sure string is always 0-terminated

[ Upstream commit 2dc85bf323515e59e15dfa858d1472bb25cad0fe ]

uaddr->sa_data is exactly of size 14, which is hard-coded here and
passed as a size argument to strncpy(). A device name can be of size
IFNAMSIZ (== 16), meaning we might leave the destination string
unterminated. Thus, use strlcpy() and also sizeof() while we're
at it. We need to memset the data area beforehand, since strlcpy
does not padd the remaining buffer with zeroes for user space, so
that we do not possibly leak anything.

Signed-off-by: Daniel Borkmann <dborkman@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/packet/af_packet.c