]> git.hungrycats.org Git - linux/commit
sh: intc: Fix use-after-free bug in register_intc_controller()
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 23 Oct 2024 08:41:59 +0000 (11:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 9 Dec 2024 09:33:00 +0000 (10:33 +0100)
commitb8b84dcdf3ab1d414304819f824b10efba64132c
treea85b7f06fdfccbf08e49c1baefebebe3bb9604cc
parent906cdbdd3b018ff69cc830173bce277a847d4fdc
sh: intc: Fix use-after-free bug in register_intc_controller()

[ Upstream commit 63e72e551942642c48456a4134975136cdcb9b3c ]

In the error handling for this function, d is freed without ever
removing it from intc_list which would lead to a use after free.
To fix this, let's only add it to the list after everything has
succeeded.

Fixes: 2dcec7a988a1 ("sh: intc: set_irq_wake() support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/sh/intc/core.c