]> git.hungrycats.org Git - linux/commit
lan78xx: Don't reset the interface on open
authorPhil Elwell <phil@raspberrypi.org>
Tue, 10 Apr 2018 12:18:25 +0000 (13:18 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 4 Nov 2018 13:52:45 +0000 (14:52 +0100)
commitb9627a218e2b2a42b812499ccb5d92707482d5d0
treebda867bd56664a89b3417ff9d9ad0a7320134a30
parentf18ed65d70f019aae09437e5b6a317d365571208
lan78xx: Don't reset the interface on open

[ Upstream commit 47b998653fea4ef69e3e89574956386f262bccca ]

Commit 92571a1aae40 ("lan78xx: Connect phy early") moves the PHY
initialisation into lan78xx_probe, but lan78xx_open subsequently calls
lan78xx_reset. As well as forcing a second round of link negotiation,
this reset frequently prevents the phy interrupt from being generated
(even though the link is up), rendering the interface unusable.

Fix this issue by removing the lan78xx_reset call from lan78xx_open.

Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell <phil@raspberrypi.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/usb/lan78xx.c