]> git.hungrycats.org Git - linux/commit
[PATCH] PCI: warn of missing pci_disable_device()
authorKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Wed, 6 Oct 2004 05:50:32 +0000 (22:50 -0700)
committerGreg Kroah-Hartman <greg@kroah.com>
Wed, 6 Oct 2004 05:50:32 +0000 (22:50 -0700)
commitbd587aa0e1b9a5985076bdda7230ce60924b0e07
treeb7e1c54b1ad498f88695bb41b59893eb54db8dba
parent6b8b1d3ccfec8efe5381ccfca10de2f168350175
[PATCH] PCI: warn of missing pci_disable_device()

As mentioned in Documentaion/pci.txt, pci device driver should call
pci_disable_device() when it decides to stop using the device. But
there are some drivers that don't use pci_disable_device() so far.

This patch adds warning messages that are displayed if the device is
removed without properly calling pci_disable_device().

'WARN_ON(1)' is commented out for now because I guess many people
(including some distros) enables 'CONFIG_DEBUG_KERNEL'. People might
be surprised if many stack dumps are displayed on their console.

Signed-off-by: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/pci/pci-driver.c