]> git.hungrycats.org Git - linux/commit
scsi: megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression
authorSumit Saxena <sumit.saxena@broadcom.com>
Wed, 9 Nov 2016 10:59:42 +0000 (02:59 -0800)
committerSasha Levin <alexander.levin@verizon.com>
Fri, 23 Dec 2016 14:05:27 +0000 (09:05 -0500)
commitc27edfb64bbff3cd5d8fc723161128dd4bb57789
treec0527250f1d52b9f1fb0dce568b72ebe17b4c357
parent016d02981cceb7b0f3436278b71fe3ea87542e20
scsi: megaraid_sas: fix macro MEGASAS_IS_LOGICAL to avoid regression

[ Upstream commit 5e5ec1759dd663a1d5a2f10930224dd009e500e8 ]

This patch will fix regression caused by commit 1e793f6fc0db ("scsi:
megaraid_sas: Fix data integrity failure for JBOD (passthrough)
devices").

The problem was that the MEGASAS_IS_LOGICAL macro did not have braces
and as a result the driver ended up exposing a lot of non-existing SCSI
devices (all SCSI commands to channels 1,2,3 were returned as
SUCCESS-DID_OK by driver).

[mkp: clarified patch description]

Fixes: 1e793f6fc0db920400574211c48f9157a37e3945
Reported-by: Jens Axboe <axboe@kernel.dk>
CC: stable@vger.kernel.org
Signed-off-by: Kashyap Desai <kashyap.desai@broadcom.com>
Signed-off-by: Sumit Saxena <sumit.saxena@broadcom.com>
Tested-by: Sumit Saxena <sumit.saxena@broadcom.com>
Reviewed-by: Tomas Henzl <thenzl@redhat.com>
Tested-by: Jens Axboe <axboe@fb.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
drivers/scsi/megaraid/megaraid_sas.h