]> git.hungrycats.org Git - linux/commit
media: v4l2-tpg: prevent the risk of a division by zero
authorMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 16 Oct 2024 09:53:15 +0000 (11:53 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 14 Nov 2024 12:15:14 +0000 (13:15 +0100)
commitc63c30c9d9f2c8de34b16cd2b8400240533b914e
tree63ef78f2b723669178ce7d541130963bea80eec4
parent4b132a464f9fa23f3c1d28de9679a525bb10c99c
media: v4l2-tpg: prevent the risk of a division by zero

commit e6a3ea83fbe15d4818d01804e904cbb0e64e543b upstream.

As reported by Coverity, the logic at tpg_precalculate_line()
blindly rescales the buffer even when scaled_witdh is equal to
zero. If this ever happens, this will cause a division by zero.

Instead, add a WARN_ON_ONCE() to trigger such cases and return
without doing any precalculation.

Fixes: 63881df94d3e ("[media] vivid: add the Test Pattern Generator")
Cc: stable@vger.kernel.org
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c