]> git.hungrycats.org Git - linux/commit
gpio: make sure gpiod_to_irq() returns negative on NULL desc
authorLinus Walleij <linus.walleij@linaro.org>
Wed, 15 Jun 2016 20:57:38 +0000 (22:57 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 24 Jun 2016 17:22:06 +0000 (10:22 -0700)
commitc6ad700afe337609d7d0ee37be0e469f08e86a1a
tree6accdb44ab3de73fddfed759fb67b06e04744615
parenta5b62e5e2089996dc87189ea605f9f16e8920528
gpio: make sure gpiod_to_irq() returns negative on NULL desc

commit 79bb71bd1d93197ce227fa167b450b633f30a52b upstream.

commit 54d77198fdfbc4f0fe11b4252c1d9c97d51a3264
("gpio: bail out silently on NULL descriptors")
doesn't work for gpiod_to_irq(): drivers assume that NULL
descriptors will give negative IRQ numbers in return.

It has been pointed out that returning 0 is NO_IRQ and that
drivers should be amended to treat this as an error, but that
is for the longer term: now let us repair the semantics.

Cc: Maxime Ripard <maxime.ripard@free-electrons.com>
Reported-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpio/gpiolib.c