]> git.hungrycats.org Git - linux/commit
libata: Fix command retry decision
authorDamien Le Moal <damien.lemoal@wdc.com>
Wed, 9 May 2018 00:28:12 +0000 (09:28 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 3 Aug 2018 05:55:22 +0000 (07:55 +0200)
commitcbc0c24c9c9f51c5b4d429bbd6230a8660628462
treef3a0c511d1246e1ecf6c776df8a08c8d14296854
parentf3be42dc93677e7d6807a6521569b4cea772b140
libata: Fix command retry decision

[ Upstream commit 804689ad2d9b66d0d3920b48cf05881049d44589 ]

For failed commands with valid sense data (e.g. NCQ commands),
scsi_check_sense() is used in ata_analyze_tf() to determine if the
command can be retried. In such case, rely on this decision and ignore
the command error mask based decision done in ata_worth_retry().

This fixes useless retries of commands such as unaligned writes on zoned
disks (TYPE_ZAC).

Signed-off-by: Damien Le Moal <damien.lemoal@wdc.com>
Reviewed-by: Hannes Reinecke <hare@suse.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/ata/libata-eh.c