]> git.hungrycats.org Git - linux/commit
audit: correct a type mismatch in audit_syscall_exit()
authorAKASHI Takahiro <takahiro.akashi@linaro.org>
Mon, 13 Jan 2014 21:33:09 +0000 (13:33 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Feb 2014 19:51:08 +0000 (11:51 -0800)
commitcd1188e7a59ca6c03cab5fe490bf18888a3ca5dc
tree0190e9cc1c4755e196580ebe407525e9b87f715e
parent559316545580bbc61cf839e164c8a4c871c6ba42
audit: correct a type mismatch in audit_syscall_exit()

commit 06bdadd7634551cfe8ce071fe44d0311b3033d9e upstream.

audit_syscall_exit() saves a result of regs_return_value() in intermediate
"int" variable and passes it to __audit_syscall_exit(), which expects its
second argument as a "long" value.  This will result in truncating the
value returned by a system call and making a wrong audit record.

I don't know why gcc compiler doesn't complain about this, but anyway it
causes a problem at runtime on arm64 (and probably most 64-bit archs).

Signed-off-by: AKASHI Takahiro <takahiro.akashi@linaro.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Eric Paris <eparis@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
include/linux/audit.h