]> git.hungrycats.org Git - linux/commit
lib/test_hmm.c: handle src_pfns and dst_pfns allocation failure
authorDuoming Zhou <duoming@zju.edu.cn>
Tue, 12 Mar 2024 00:59:05 +0000 (08:59 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:45 +0000 (09:49 +0200)
commitce47e8ead9a72834cc68431d53f8092ce69bebb7
tree8dc8cb1d8752e8691c142049e6ef2b33aa3c885b
parent264dd6fe25b64e5189bd8a2151d24e205b02d927
lib/test_hmm.c: handle src_pfns and dst_pfns allocation failure

[ Upstream commit c2af060d1c18beaec56351cf9c9bcbbc5af341a3 ]

The kcalloc() in dmirror_device_evict_chunk() will return null if the
physical memory has run out.  As a result, if src_pfns or dst_pfns is
dereferenced, the null pointer dereference bug will happen.

Moreover, the device is going away.  If the kcalloc() fails, the pages
mapping a chunk could not be evicted.  So add a __GFP_NOFAIL flag in
kcalloc().

Finally, as there is no need to have physically contiguous memory, Switch
kcalloc() to kvcalloc() in order to avoid failing allocations.

Link: https://lkml.kernel.org/r/20240312005905.9939-1-duoming@zju.edu.cn
Fixes: b2ef9f5a5cb3 ("mm/hmm/test: add selftest driver for HMM")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Cc: Jérôme Glisse <jglisse@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
lib/test_hmm.c