]> git.hungrycats.org Git - linux/commit
wifi: brcmfmac: release 'root' node in all execution paths
authorJavier Carrasco <javier.carrasco.cruz@gmail.com>
Wed, 30 Oct 2024 17:34:45 +0000 (18:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:54:15 +0000 (13:54 +0100)
commitcf3998254f02b60234dcedef6b2979e7208b3f58
treea3ef5b0890f421f5c68c3ae3cf8bba4205307fa3
parent2eec88c0fa63f8ad35704a8c9df0b5bd8694fcda
wifi: brcmfmac: release 'root' node in all execution paths

commit 2e19a3b590ebf2e351fc9d0e7c323430e65b6b6d upstream.

The fixed patch introduced an additional condition to enter the scope
where the 'root' device_node is released (!settings->board_type,
currently 'err'), which avoid decrementing the refcount with a call to
of_node_put() if that second condition is not satisfied.

Move the call to of_node_put() to the point where 'root' is no longer
required to avoid leaking the resource if err is not zero.

Cc: stable@vger.kernel.org
Fixes: 7682de8b3351 ("wifi: brcmfmac: of: Fetch Apple properties")
Signed-off-by: Javier Carrasco <javier.carrasco.cruz@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20241030-brcmfmac-of-cleanup-v1-1-0b90eefb4279@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/wireless/broadcom/brcm80211/brcmfmac/of.c