]> git.hungrycats.org Git - linux/commit
projects / linux / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: d67a614) | patch
[PATCH] wan/z8530 deadlocks
authorStephen Hemminger <shemminger@osdl.org>
Sat, 27 Sep 2003 02:32:06 +0000 (22:32 -0400)
committerStephen Hemminger <shemminger@osdl.org>
Sat, 27 Sep 2003 02:32:06 +0000 (22:32 -0400)
commitcf967453dd988774b5ddf64390d400bb73bc7980
tree0def8a0c3650c9c6bfee113969c3e7cf1f9d3a0etree | snapshot
parentd67a614e2191cb737f67f52b2fac1b1f8032ccd9commit | diff
[PATCH] wan/z8530 deadlocks

Existing code for drivers/net/wan/z8530 is riddled with self-deadlocks
and irq flag confusion.  For example:
z8530_init -> do_z8530_init -> write_zsreg
self deadlocks on the channel lock.

Several places acquire both the channel and dma lock and then
reuse the same irq flags variable - ouch.

This code at least, correctly probes (for no device case) on SMP.
Other paths verified by inspection.
drivers/net/wan/z85230.c diff | blob | history
Linux kernels and configurations used by Zygo.