]> git.hungrycats.org Git - linux/commit
clk: bcm: rpi: Fix off by one in raspberrypi_discover_clocks()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 21 Apr 2023 10:41:01 +0000 (13:41 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jul 2023 17:39:42 +0000 (19:39 +0200)
commitd0f4af90ad8f974ee2ab0be4984a7cc14bb1cd89
tree305f33138963e9cf51aac07ca47f2ee9e768175a
parent3eb86a15fd674af15f2da470bdfbb271300c792a
clk: bcm: rpi: Fix off by one in raspberrypi_discover_clocks()

[ Upstream commit da2edb3e3c09fd1451b7f400ccd1070ef086619a ]

Smatch detected an off by one in this code:
    drivers/clk/bcm/clk-raspberrypi.c:374 raspberrypi_discover_clocks()
    error: buffer overflow 'data->hws' 16 <= 16

The data->hws[] array has RPI_FIRMWARE_NUM_CLK_ID elements so the >
comparison needs to changed to >=.

Fixes: 12c90f3f27bb ("clk: bcm: rpi: Add variant structure")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/5a850b08-d2f5-4794-aceb-a6b468965139@kili.mountain
Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/clk/bcm/clk-raspberrypi.c