]> git.hungrycats.org Git - linux/commit
ALSA: firewire-lib: Avoid division by zero in apply_constraint_to_size()
authorAndrey Shumilin <shum.sdl@nppct.ru>
Fri, 18 Oct 2024 06:00:18 +0000 (09:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 1 Nov 2024 00:56:05 +0000 (01:56 +0100)
commitd2826873db70a6719cdd9212a6739f3e6234cfc4
tree105b1f1c8b2fd5f4144acb9056cd60f2e947a51d
parent02753a90102cbfa465d09c5aa91350655254ef54
ALSA: firewire-lib: Avoid division by zero in apply_constraint_to_size()

[ Upstream commit 72cafe63b35d06b5cfbaf807e90ae657907858da ]

The step variable is initialized to zero. It is changed in the loop,
but if it's not changed it will remain zero. Add a variable check
before the division.

The observed behavior was introduced by commit 826b5de90c0b
("ALSA: firewire-lib: fix insufficient PCM rule for period/buffer size"),
and it is difficult to show that any of the interval parameters will
satisfy the snd_interval_test() condition with data from the
amdtp_rate_table[] table.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 826b5de90c0b ("ALSA: firewire-lib: fix insufficient PCM rule for period/buffer size")
Signed-off-by: Andrey Shumilin <shum.sdl@nppct.ru>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20241018060018.1189537-1-shum.sdl@nppct.ru
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/firewire/amdtp-stream.c