]> git.hungrycats.org Git - linux/commit
soundwire: cadence: Don't overwrite msg->buf during write commands
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Fri, 16 Sep 2022 10:35:05 +0000 (11:35 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Oct 2022 07:58:25 +0000 (09:58 +0200)
commitd4188d2e2842496354e2a6daa9691a869d6d96c9
treec27c5b3e61adb2a31807396319fadc0da1fec115
parent864934cbe72c709d9e1f64b530ca135dbfb24c30
soundwire: cadence: Don't overwrite msg->buf during write commands

[ Upstream commit ba05b39d265bdd16913f7684600d9d41e2796745 ]

The buf passed in struct sdw_msg must only be written for a READ,
in that case the RDATA part of the response is the data value of the
register.

For a write command there is no RDATA, and buf should be assumed to
be const and unmodifable. The original caller should not expect its data
buffer to be corrupted by an sdw_nwrite().

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Link: https://lore.kernel.org/r/20220916103505.1562210-1-rf@opensource.cirrus.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/soundwire/cadence_master.c