]> git.hungrycats.org Git - linux/commit
btrfs: zero the buffer before marking it dirty in btrfs_redirty_list_add
authorChristoph Hellwig <hch@lst.de>
Mon, 8 May 2023 14:58:37 +0000 (07:58 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 17 May 2023 11:58:57 +0000 (13:58 +0200)
commitd80677142a5a74fe9cb432a33a426bd652d25bc0
tree22cfcd1bdce603df464fae0c319d61b61ce0b103
parent04ff6bd0317735791ef3e443c7c89f3c0dda548d
btrfs: zero the buffer before marking it dirty in btrfs_redirty_list_add

commit c83b56d1dd87cf67492bb770c26d6f87aee70ed6 upstream.

btrfs_redirty_list_add zeroes the buffer data and sets the
EXTENT_BUFFER_NO_CHECK to make sure writeback is fine with a bogus
header.  But it does that after already marking the buffer dirty, which
means that writeback could already be looking at the buffer.

Switch the order of operations around so that the buffer is only marked
dirty when we're ready to write it.

Fixes: d3575156f662 ("btrfs: zoned: redirty released extent buffers")
CC: stable@vger.kernel.org # 5.15+
Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/btrfs/zoned.c