]> git.hungrycats.org Git - linux/commit
ALSA: usb-audio: Fix runtime PM unbalance
authorTakashi Iwai <tiwai@suse.de>
Wed, 19 Aug 2015 05:20:14 +0000 (07:20 +0200)
committerJiri Slaby <jslaby@suse.cz>
Mon, 28 Nov 2016 21:22:52 +0000 (22:22 +0100)
commitdbb41290b2033840bf962d987c575fb3c8e11807
tree1ca5dbb7dfc3a5d73f80f061d30158161fa21709
parent6417d6f2e707a0bcf5b4fd13c0b184d4ba41c4d0
ALSA: usb-audio: Fix runtime PM unbalance

commit 9003ebb13f61e8c78a641e0dda7775183ada0625 upstream.

The fix for deadlock in PM in commit [1ee23fe07ee8: ALSA: usb-audio:
Fix deadlocks at resuming] introduced a new check of in_pm flag.
However, the brainless patch author evaluated it in a wrong way
(logical AND instead of logical OR), thus usb_autopm_get_interface()
is wrongly called at probing, leading to unbalance of runtime PM
refcount.

This patch fixes it by correcting the logic.

Reported-by: Hans Yang <hansy@nvidia.com>
Fixes: 1ee23fe07ee8 ('ALSA: usb-audio: Fix deadlocks at resuming')
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
sound/usb/card.c