]> git.hungrycats.org Git - linux/commit
firmware: cs_dsp: Fix new control name check
authorVlad Karpovich <vkarpovi@opensource.cirrus.com>
Tue, 15 Aug 2023 17:29:08 +0000 (12:29 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2023 07:48:19 +0000 (09:48 +0200)
commitdc98c6c08692ae3b25be3a2a0d4a5489019b9499
treec57da3bb80d165fa4bcea1993c4b857aa84aabb4
parent7a8b6d93991bf4b72b3f959baea35397c6c8e521
firmware: cs_dsp: Fix new control name check

[ Upstream commit 7ac1102b227b36550452b663fd39ab1c09378a95 ]

Before adding a new FW control, its name is checked against
existing controls list. But the string length in strncmp used
to compare controls names is taken from the list, so if beginnings
of the controls are matching,  then the new control is not created.
For example, if CAL_R control already exists, CAL_R_SELECTED
is not created.
The fix is to compare string lengths as well.

Fixes: 6477960755fb ("ASoC: wm_adsp: Move check for control existence")
Signed-off-by: Vlad Karpovich <vkarpovi@opensource.cirrus.com>
Link: https://lore.kernel.org/r/20230815172908.3454056-1-vkarpovi@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/cirrus/cs_dsp.c