]> git.hungrycats.org Git - linux/commit
of: module: add buffer overflow check in of_modalias()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sun, 14 Apr 2024 08:51:39 +0000 (11:51 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 May 2024 07:49:48 +0000 (09:49 +0200)
commitee332023adfd5882808f2dabf037b32d6ce36f9e
tree8de6bd138898071faa262093eacef4773e9044fe
parenta3c7649d47069f00e44838036e2ef263237f7a37
of: module: add buffer overflow check in of_modalias()

[ Upstream commit cf7385cb26ac4f0ee6c7385960525ad534323252 ]

In of_modalias(), if the buffer happens to be too small even for the 1st
snprintf() call, the len parameter will become negative and str parameter
(if not NULL initially) will point beyond the buffer's end. Add the buffer
overflow check after the 1st snprintf() call and fix such check after the
strlen() call (accounting for the terminating NUL char).

Fixes: bc575064d688 ("of/device: use of_property_for_each_string to parse compatible strings")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/bbfc6be0-c687-62b6-d015-5141b93f313e@omp.ru
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/of/module.c