]> git.hungrycats.org Git - linux/commit
block: use after free bug in __blkdev_get
authorNeil Brown <neilb@suse.de>
Mon, 26 Oct 2009 07:59:17 +0000 (08:59 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 8 Dec 2009 18:22:27 +0000 (10:22 -0800)
commitee3989464a4c4896ec29f5b1c2aae840fab8b73d
tree45325c8135975b8fd9160c2e0814a0cdf8742c60
parentbb969fdc8c7e7675266a3697ad93945428fd89d6
block: use after free bug in __blkdev_get

commit 960cc0f4fef607baabc2232fbd7cce5368a9dcfd upstream.

commit 0762b8bde9729f10f8e6249809660ff2ec3ad735
(from 14 months ago) introduced a use-after-free bug which has just
recently started manifesting in my md testing.
I tried git bisect to find out what caused the bug to start
manifesting, and it could have been the recent change to
blk_unregister_queue (48c0d4d4c04) but the results were inconclusive.

This patch certainly fixes my symptoms and looks correct as the two
calls are now in the same order as elsewhere in that function.

Signed-off-by: NeilBrown <neilb@suse.de>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
fs/block_dev.c