]> git.hungrycats.org Git - linux/commit
[PATCH] AIO/DIO oops fix
authorBadari Pulavarty <pbadari@us.ibm.com>
Wed, 8 Sep 2004 00:56:52 +0000 (17:56 -0700)
committerLinus Torvalds <torvalds@ppc970.osdl.org>
Wed, 8 Sep 2004 00:56:52 +0000 (17:56 -0700)
commitf1311f43e2b05f9fcb3e72fea8dbf00f79ef64e8
treedb759aa57109ff7fae4cbc6538ec907cf29981bf
parent9c04fd703a714a00b34761024bf0c9ba3c32d898
[PATCH] AIO/DIO oops fix

The problem here is, finished_one_bio() shouldn't call aio_complete() since
no work has been done.  I have a fix for this - can you verify this ?  I am
not really comfortable with this "tweaking".  (I am not really sure about
IO errors like EIO etc.  - if they can lead to calling aio_complete()
twice)

Fix is to call aio_complete() ONLY if there is something to report.  Note
the we don't update dio->result with any error codes from get_user_pages(),
they just passed as "ret" value from do_direct_IO().

Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
fs/direct-io.c