]> git.hungrycats.org Git - linux/commit
md/raid1: don't abort a resync on the first badblock.
authorNeilBrown <neilb@suse.de>
Tue, 31 Jul 2012 00:05:34 +0000 (10:05 +1000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 15 Aug 2012 15:10:08 +0000 (08:10 -0700)
commitfb060f3d95d29c385063151c8a09faa4d1a02f2f
tree91806e31b0b68b68280a1ce738c41ae9679454b4
parentcc9fdb9cdde35aafad3b11ce74e244f5da7ac3c0
md/raid1: don't abort a resync on the first badblock.

commit b7219ccb33aa0df9949a60c68b5e9f712615e56f upstream.

If a resync of a RAID1 array with 2 devices finds a known bad block
one device it will neither read from, or write to, that device for
this block offset.
So there will be one read_target (The other device) and zero write
targets.
This condition causes md/raid1 to abort the resync assuming that it
has finished - without known bad blocks this would be true.

When there are no write targets because of the presence of bad blocks
we should only skip over the area covered by the bad block.
RAID10 already gets this right, raid1 doesn't.  Or didn't.

As this can cause a 'sync' to abort early and appear to have succeeded
it could lead to some data corruption, so it suitable for -stable.

Reported-by: Alexander Lyakas <alex.bolshoy@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/md/raid1.c