]> git.hungrycats.org Git - linux/commit
drm/i915: try not to lose backlight CBLV precision
authorJani Nikula <jani.nikula@intel.com>
Fri, 23 Aug 2013 07:50:39 +0000 (10:50 +0300)
committerBen Hutchings <ben@decadent.org.uk>
Sat, 26 Oct 2013 20:06:02 +0000 (21:06 +0100)
commitfbeecda256bab53034d5a7f0c79c2f99219ce7c3
tree2a9e9aa34dc279bde171e90919465e60d07fd4fe
parente4f24883632f4d46d4b43ae37a76932343a69839
drm/i915: try not to lose backlight CBLV precision

commit cac6a5ae0118832936eb162ec4cedb30f2422bcc upstream.

ACPI has _BCM and _BQC methods to set and query the backlight
brightness, respectively. The ACPI opregion has variables BCLP and CBLV
to hold the requested and current backlight brightness, respectively.

The BCLP variable has range 0..255 while the others have range
0..100. This means the _BCM method has to scale the brightness for BCLP,
and the gfx driver has to scale the requested value back for CBLV. If
the _BQC method uses the CBLV variable (apparently some implementations
do, some don't) for current backlight level reporting, there's room for
rounding errors.

Use DIV_ROUND_UP for scaling back to CBLV to get back to the same values
that were passed to _BCM, presuming the _BCM simply uses bclp = (in *
255) / 100 for scaling to BCLP.

Reference: https://gist.github.com/aaronlu/6314920
Reported-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Aaron Lu <aaron.lu@intel.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
[bwh: Backported to 3.2:
 - Adjust context
 - ASLE region is treated as normal memory rather than __iomem]
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
drivers/gpu/drm/i915/intel_opregion.c