]> git.hungrycats.org Git - linux/commit
Btrfs: fix unprotected deletion from pending_chunks list
authorFilipe Manana <fdmanana@suse.com>
Tue, 2 Dec 2014 18:07:49 +0000 (18:07 +0000)
committerZygo Blaxell <zblaxell@serenity.furryterror.org>
Sun, 14 Dec 2014 03:36:41 +0000 (22:36 -0500)
commitfcd11ba249f4448ee0fec3b04e313492d63c7102
treeadf3726109987811f69bd9f855c848eca7064ac2
parent4adf68b7abda85a2eaa8e8bf4fb0fc548424fecb
Btrfs: fix unprotected deletion from pending_chunks list

On block group remove if the corresponding extent map was on the
transaction->pending_chunks list, we were deleting the extent map
from that list, through remove_extent_mapping(), without any
synchronization with chunk allocation (which iterates that list
and adds new elements to it). Fix this by ensure that this is done
while the chunk mutex is held, since that's the mutex that protects
the list in the chunk allocation code path.

This applies on top (depends on) of my previous patch titled:
"Btrfs: fix race between fs trimming and block group remove/allocation"

But the issue in fact was already present before that change, it only
became easier to hit after Josef's 3.18 patch that added automatic
removal of empty block groups.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: Chris Mason <clm@fb.com>
(cherry picked from commit 8dbcd10f6978ca3ccee2f43288d16b7b9da2fb2b)
fs/btrfs/extent-tree.c