]> git.hungrycats.org Git - linux/commit
KVM: guest_memfd: Establish memslot<=>guest_memfd bindings *after* memslot is ready
authorSean Christopherson <seanjc@google.com>
Tue, 22 Sep 2026 00:13:31 +0000 (17:13 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 6 Nov 2026 17:10:49 +0000 (12:10 -0500)
commitfd224f1778e13660aec4e1f51fcdaeab5794e7ee
tree49a5935b93ab87dbb694345a064c35789cea7892
parent024be82ac4c4df650cc6daca6d7db79daee95470
KVM: guest_memfd: Establish memslot<=>guest_memfd bindings *after* memslot is ready

commit 3fe5d2944e5ac3fc5073344b0982c73703332e18 upstream.

Wait to bind a memslot to a guest_memfd instance until *after* the memslot
is fully prepared, as creating the binding in guest_memfd will effectively
expose the memslot to readers.  As pointed out by Sashiko, binding the
memslot before it's ready to be exposed to the rest of the world can break
various memslot assumption and rules.  E.g. x86 could observe a NULL rmap
pointer if a PUNCH_HOLE hit the guest_memfd after the binding was created,
but before KVM made it through kvm_prepare_memory_region().

Fixes: a7800aa80ea4 ("KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory")
Cc: stable@vger.kernel.org
Reported-by: Sashiko Bot <sashiko-bot@kernel.org>
Closes: https://lore.kernel.org/all/20260826170551.BEF801F000E9@smtp.kernel.org
Link: https://patch.msgid.link/20260922001332.1121266-6-seanjc@google.com
Signed-off-by: Sean Christopherson <seanjc@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
virt/kvm/kvm_main.c