Fix signedness tests in vsnprintf by making it explicit.

It used to depend on us having a signed type (which in turn is
incorrect for the later division).

diff --git a/lib/vsprintf.c b/lib/vsprintf.c
index bc699e295bce939f45b31c0b16e4e38bd70185d7..0a12089169a61e5d2cb3f793ea6c9d803681462f 100644 (file)
--- a/lib/vsprintf.c
+++ b/lib/vsprintf.c
@@ -143,9 +143,9 @@ static char * number(char * buf, char * end, unsigned long long num, int base, i
        c = (type & ZEROPAD) ? '0' : ' ';
        sign = 0;
        if (type & SIGN) {
-               if (num < 0) {
+               if ((signed long long) num < 0) {
                        sign = '-';
-                       num = -num;
+                       num = - (signed long long) num;
                        size--;
                } else if (type & PLUS) {
                        sign = '+';