]> git.hungrycats.org Git - linux/commitdiff
iio: adc: ad4000: Check for error code from devm_mutex_init() call
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 30 Oct 2024 16:19:18 +0000 (18:19 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 13:02:37 +0000 (14:02 +0100)
[ Upstream commit 8ebfd09255219ae55f8a101f6aeb0f64dd780d88 ]

Even if it's not critical, the avoidance of checking the error code
from devm_mutex_init() call today diminishes the point of using devm
variant of it. Tomorrow it may even leak something. Add the missed
check.

Fixes: 938fd562b974 ("iio: adc: Add support for AD4000")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20241030162013.2100253-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/adc/ad4000.c

index fc9c9807f89d2604e760bdb54368d34d148c739b..b3b82535f5c14dfe4a5db1c8aa69fd13d1283de7 100644 (file)
@@ -639,7 +639,9 @@ static int ad4000_probe(struct spi_device *spi)
        indio_dev->name = chip->dev_name;
        indio_dev->num_channels = 1;
 
-       devm_mutex_init(dev, &st->lock);
+       ret = devm_mutex_init(dev, &st->lock);
+       if (ret)
+               return ret;
 
        st->gain_milli = 1000;
        if (chip->has_hardware_gain) {