]> git.hungrycats.org Git - linux/commitdiff
usb: gadget: f_ncm: allow using NCM in SuperSpeed Plus gadgets.
authorLorenzo Colitti <lorenzo@google.com>
Tue, 25 Aug 2020 05:55:05 +0000 (14:55 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:08:30 +0000 (10:08 +0100)
[ Upstream commit 7974ecd7d3c0f42a98566f281e44ea8573a2ad88 ]

Currently, enabling f_ncm at SuperSpeed Plus speeds results in an
oops in config_ep_by_speed because ncm_set_alt passes in NULL
ssp_descriptors. Fix this by re-using the SuperSpeed descriptors.
This is safe because usb_assign_descriptors calls
usb_copy_descriptors.

Tested: enabled f_ncm on a dwc3 gadget and 10Gbps link, ran iperf
Reviewed-by: Maciej Żenczykowski <maze@google.com>
Signed-off-by: Lorenzo Colitti <lorenzo@google.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/gadget/function/f_ncm.c

index 7672fa25085b068dac890dd9a23310b0e4969887..92a7c3a839454a641a14cfb53dff5c7848879c0c 100644 (file)
@@ -1536,7 +1536,7 @@ static int ncm_bind(struct usb_configuration *c, struct usb_function *f)
                fs_ncm_notify_desc.bEndpointAddress;
 
        status = usb_assign_descriptors(f, ncm_fs_function, ncm_hs_function,
-                       ncm_ss_function, NULL);
+                       ncm_ss_function, ncm_ss_function);
        if (status)
                goto fail;