]> git.hungrycats.org Git - linux/commitdiff
drm/msm/dsi: Drop dev_pm_opp_set_rate(0)
authorKonrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Tue, 28 Jul 2026 13:20:47 +0000 (15:20 +0200)
committerDmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Fri, 31 Jul 2026 14:08:01 +0000 (17:08 +0300)
dev_pm_opp_set_rate(0) removes the vote specified in required-opps but
does not actually park the clock, making it run without the necessary
power backing. Drop the explicit call to it.

Every call site of ops->link_clk_disable() is followed by
pm_runtime_put(), so the power vote will be rescinded if deemed safe.

Fixes: 32d3e0feccfe ("drm/msm: dsi: Use OPP API to set clk/perf state")
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/742783/
Link: https://lore.kernel.org/r/20260728-topic-dpu_power-v1-3-e7783b859a70@oss.qualcomm.com
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
drivers/gpu/drm/msm/dsi/dsi_host.c

index 59125d342fcb6c17b7d2462049df3dc3666c4db0..7e4e3718b536c92dc555de213042857379499447 100644 (file)
@@ -550,8 +550,6 @@ error:
 
 void dsi_link_clk_disable_6g(struct msm_dsi_host *msm_host)
 {
-       /* Drop the performance state vote */
-       dev_pm_opp_set_rate(&msm_host->pdev->dev, 0);
        clk_disable_unprepare(msm_host->esc_clk);
        clk_disable_unprepare(msm_host->pixel_clk);
        clk_disable_unprepare(msm_host->byte_intf_clk);