[PATCH] /proc/kallsyms problem

From David Mosberger:

> We definitely are seeing some strange crashes in get_ksymbol_core().
> I think the reason is the lack of iterator initialization.

Yes, looks good: reset the iterator at allocation.

diff --git a/kernel/kallsyms.c b/kernel/kallsyms.c
index dffcbfbd1343049e06f5aad60df866b9618b6a62..b3fe9efb0866b38b51b1a3d67cb42cc869b8c3c8 100644 (file)
--- a/kernel/kallsyms.c
+++ b/kernel/kallsyms.c
@@ -252,6 +252,7 @@ static int kallsyms_open(struct inode *inode, struct file *file)
        iter = kmalloc(sizeof(*iter), GFP_KERNEL);
        if (!iter)
                return -ENOMEM;
+       reset_iter(iter);
 
        ret = seq_open(file, &kallsyms_op);
        if (ret == 0)