]> git.hungrycats.org Git - linux/commitdiff
virtio_console: init work unconditionally
authorMichael S. Tsirkin <mst@redhat.com>
Thu, 5 Mar 2015 00:15:30 +0000 (10:45 +1030)
committerZefan Li <lizefan@huawei.com>
Fri, 19 Jun 2015 03:40:25 +0000 (11:40 +0800)
commit 4f6e24ed9de8634d6471ef86b382cba6d4e57ca8 upstream.

when multiport is off, we don't initialize config work,
but we then cancel uninitialized control_work on freeze.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Reviewed-by: Amit Shah <amit.shah@redhat.com>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/char/virtio_console.c

index a81f4694f3220a2acb9f5dd02cb62f1f8b552bd0..82650b4b62a1a4d1681ec960f3cdb7821ef93693 100644 (file)
@@ -1752,12 +1752,13 @@ static int __devinit virtcons_probe(struct virtio_device *vdev)
        spin_lock_init(&portdev->ports_lock);
        INIT_LIST_HEAD(&portdev->ports);
 
+       INIT_WORK(&portdev->control_work, &control_work_handler);
+
        if (multiport) {
                unsigned int nr_added_bufs;
 
                spin_lock_init(&portdev->c_ivq_lock);
                spin_lock_init(&portdev->c_ovq_lock);
-               INIT_WORK(&portdev->control_work, &control_work_handler);
 
                nr_added_bufs = fill_queue(portdev->c_ivq,
                                           &portdev->c_ivq_lock);