]> git.hungrycats.org Git - linux/commitdiff
hwmon: (pmbus/adm1275) Accept negative page register values
authorGuenter Roeck <linux@roeck-us.net>
Sun, 11 Mar 2018 01:55:47 +0000 (17:55 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 May 2018 05:49:13 +0000 (07:49 +0200)
[ Upstream commit ecb29abd4cb0670c616fb563a078f25d777ce530 ]

A negative page register value means that no page needs to be
selected. This is used by status register read operations and needs
to be accepted. The failure to do so so results in missed status
and limit registers.

Fixes: da8e48ab483e1 ("hwmon: (pmbus) Always call _pmbus_read_byte in core driver")
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/hwmon/pmbus/adm1275.c

index 18477dd1e2437608ad010cb5e9afa4a5e5ec98ca..c3f4c9ef6705d101bc40cf4574de65ee0694415b 100644 (file)
@@ -141,7 +141,7 @@ static int adm1275_read_word_data(struct i2c_client *client, int page, int reg)
        const struct adm1275_data *data = to_adm1275_data(info);
        int ret = 0;
 
-       if (page)
+       if (page > 0)
                return -ENXIO;
 
        switch (reg) {
@@ -218,7 +218,7 @@ static int adm1275_write_word_data(struct i2c_client *client, int page, int reg,
        const struct adm1275_data *data = to_adm1275_data(info);
        int ret;
 
-       if (page)
+       if (page > 0)
                return -ENXIO;
 
        switch (reg) {