]> git.hungrycats.org Git - linux/commitdiff
rtc: at91sam9: fix OF node leak in probe() error path
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Sun, 25 Aug 2024 18:31:03 +0000 (20:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Oct 2024 10:01:03 +0000 (12:01 +0200)
commit 73580e2ee6adfb40276bd420da3bb1abae204e10 upstream.

Driver is leaking an OF node reference obtained from
of_parse_phandle_with_fixed_args().

Fixes: 43e112bb3dea ("rtc: at91sam9: make use of syscon/regmap to access GPBR registers")
Cc: stable@vger.kernel.org
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240825183103.102904-1-krzysztof.kozlowski@linaro.org
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/rtc/rtc-at91sam9.c

index f93bee96e3623330b179e459b2c41e9084709f31..993c0878fb66063cc72522046a5d09913dd6651f 100644 (file)
@@ -368,6 +368,7 @@ static int at91_rtc_probe(struct platform_device *pdev)
                return ret;
 
        rtc->gpbr = syscon_node_to_regmap(args.np);
+       of_node_put(args.np);
        rtc->gpbr_offset = args.args[0];
        if (IS_ERR(rtc->gpbr)) {
                dev_err(&pdev->dev, "failed to retrieve gpbr regmap, aborting.\n");