]> git.hungrycats.org Git - linux/commitdiff
drm/amdgpu: fix potential resource leak warning
authorTim Huang <Tim.Huang@amd.com>
Thu, 25 Apr 2024 03:09:00 +0000 (11:09 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Aug 2024 13:34:12 +0000 (15:34 +0200)
[ Upstream commit 22a5daaec0660dd19740c4c6608b78f38760d1e6 ]

Clear resource leak warning that when the prepare fails,
the allocated amdgpu job object will never be released.

Signed-off-by: Tim Huang <Tim.Huang@amd.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c

index 66e8a016126b87413188a4ee37e7153cc607443d..9b748d7058b5c0548d936a8d9fdedbe5efe2e4cd 100644 (file)
@@ -102,6 +102,11 @@ static int amdgpu_vm_sdma_prepare(struct amdgpu_vm_update_params *p,
        if (!r)
                r = amdgpu_sync_push_to_job(&sync, p->job);
        amdgpu_sync_free(&sync);
+
+       if (r) {
+               p->num_dw_left = 0;
+               amdgpu_job_free(p->job);
+       }
        return r;
 }