]> git.hungrycats.org Git - linux/commitdiff
drm/amd/display: Deprecate DMUB register offload functionality
authorAustin Zheng <austin.zheng@amd.com>
Tue, 12 May 2026 20:20:54 +0000 (16:20 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 17 Jun 2026 20:08:41 +0000 (16:08 -0400)
[Why]
The DMUB register offload feature should no longer be used.
This was originally a debug feature for DCN21.
No longer applicable to the DMUB programming model.

[How]
Remove DMUB register offload infrastructure including helper
functions, structures, debug options, and register sequence macros.

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas@amd.com>
Signed-off-by: Austin Zheng <Austin.Zheng@amd.com>
Signed-off-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
Tested-by: Dan Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
20 files changed:
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
drivers/gpu/drm/amd/display/dc/dc.h
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.c
drivers/gpu/drm/amd/display/dc/dc_dmub_srv.h
drivers/gpu/drm/amd/display/dc/dc_helper.c
drivers/gpu/drm/amd/display/dc/dm_services.h
drivers/gpu/drm/amd/display/dc/dpp/dcn10/dcn10_dpp_cm.c
drivers/gpu/drm/amd/display/dc/hwss/dcn35/dcn35_hwseq.c
drivers/gpu/drm/amd/display/dc/inc/reg_helper.h
drivers/gpu/drm/amd/display/dc/mpc/dcn20/dcn20_mpc.c
drivers/gpu/drm/amd/display/dc/optc/dcn10/dcn10_optc.c
drivers/gpu/drm/amd/display/dc/optc/dcn20/dcn20_optc.c
drivers/gpu/drm/amd/display/dc/optc/dcn31/dcn31_optc.c
drivers/gpu/drm/amd/display/dc/optc/dcn314/dcn314_optc.c
drivers/gpu/drm/amd/display/dc/optc/dcn32/dcn32_optc.c
drivers/gpu/drm/amd/display/dc/optc/dcn35/dcn35_optc.c
drivers/gpu/drm/amd/display/dc/optc/dcn401/dcn401_optc.c
drivers/gpu/drm/amd/display/dc/resource/dcn35/dcn35_resource.c
drivers/gpu/drm/amd/display/dc/resource/dcn351/dcn351_resource.c
drivers/gpu/drm/amd/display/dc/resource/dcn36/dcn36_resource.c

index 1ed697a3a4532d596954d3985637ce88f23ebfdc..40f32c8024a0c2925eeac6b95f840afe20a6cd04 100644 (file)
@@ -13915,13 +13915,6 @@ uint32_t dm_read_reg_func(const struct dc_context *ctx, uint32_t address,
        }
 #endif
 
-       if (ctx->dmub_srv &&
-           ctx->dmub_srv->reg_helper_offload.gather_in_progress &&
-           !ctx->dmub_srv->reg_helper_offload.should_burst_write) {
-               ASSERT(false);
-               return 0;
-       }
-
        amdgpu_dm_exit_ips_for_hw_access(ctx->dc);
 
        value = cgs_read_register(ctx->cgs_device, address);
index 82d02ebbd82908ad5c214b6c7621f58e1e1cf221..d5d9d56fbcb8decd54f4def91fdab1015438655f 100644 (file)
@@ -1129,8 +1129,6 @@ struct dc_debug_options {
        unsigned int force_fclk_khz;
        bool enable_tri_buf;
        bool ips_disallow_entry;
-       bool dmub_offload_enabled;
-       bool dmcub_emulation;
        bool disable_idle_power_optimizations;
        unsigned int mall_size_override;
        unsigned int mall_additional_timer_percent;
@@ -1332,7 +1330,6 @@ struct dc_init_data {
        enum dce_environment dce_environment;
 
        struct dmub_offload_funcs *dmub_if;
-       struct dc_reg_helper_state *dmub_offload;
 
        struct dc_config flags;
        uint64_t log_mask;
index 0ee5c0c5545caf4b0cd4172fea4b7125cce88a4e..4c81989898e2040a87408af041c49c7fbd475dc6 100644 (file)
@@ -518,9 +518,6 @@ void dc_dmub_srv_query_caps_cmd(struct dc_dmub_srv *dc_dmub_srv)
 {
        union dmub_rb_cmd cmd = { 0 };
 
-       if (dc_dmub_srv->ctx->dc->debug.dmcub_emulation)
-               return;
-
        memset(&cmd, 0, sizeof(cmd));
 
        /* Prepare fw command */
@@ -1302,9 +1299,6 @@ bool dc_dmub_srv_is_hw_pwr_up(struct dc_dmub_srv *dc_dmub_srv, bool wait)
        if (!dc_dmub_srv || !dc_dmub_srv->dmub)
                return true;
 
-       if (dc_dmub_srv->ctx->dc->debug.dmcub_emulation)
-               return true;
-
        dc_ctx = dc_dmub_srv->ctx;
 
        if (wait) {
@@ -1345,9 +1339,6 @@ static void dc_dmub_srv_notify_idle(const struct dc *dc, bool allow_idle)
        struct dc_dmub_srv *dc_dmub_srv;
        union dmub_rb_cmd cmd = {0};
 
-       if (dc->debug.dmcub_emulation)
-               return;
-
        if (!dc->ctx->dmub_srv || !dc->ctx->dmub_srv->dmub)
                return;
 
@@ -1466,9 +1457,6 @@ static void dc_dmub_srv_exit_low_power_state(const struct dc *dc)
        struct dc_dmub_srv *dc_dmub_srv;
        uint32_t rcg_exit_count = 0, ips1_exit_count = 0, ips2_exit_count = 0, ips1z8_exit_count = 0;
 
-       if (dc->debug.dmcub_emulation)
-               return;
-
        if (!dc->ctx->dmub_srv || !dc->ctx->dmub_srv->dmub)
                return;
 
index ebcaf49e5961e710cb9194f9a73cbb31e8e7ff6c..5d399e6a83459f03672e0e4bbee200ce6af342a5 100644 (file)
@@ -37,17 +37,8 @@ struct dc_crtc_timing;
 struct dc_state;
 struct dc_surface_update;
 
-struct dc_reg_helper_state {
-       bool gather_in_progress;
-       uint32_t same_addr_count;
-       bool should_burst_write;
-       union dmub_rb_cmd cmd_data;
-       unsigned int reg_seq_count;
-};
-
 struct dc_dmub_srv {
        struct dmub_srv *dmub;
-       struct dc_reg_helper_state reg_helper_offload;
 
        struct dc_context *ctx;
        void *dm;
index 0e0165764a57ddfd0efd127e5bf503b646939bd6..cc7fea613d9e87a037ade2ef3d662b7c2736d763 100644 (file)
 #define DC_LOGGER \
        ctx->logger
 
-static inline void submit_dmub_read_modify_write(
-       struct dc_reg_helper_state *offload,
-       const struct dc_context *ctx)
-{
-       struct dmub_rb_cmd_read_modify_write *cmd_buf = &offload->cmd_data.read_modify_write;
-
-       offload->should_burst_write =
-                       (offload->same_addr_count == (DMUB_READ_MODIFY_WRITE_SEQ__MAX - 1));
-       cmd_buf->header.payload_bytes =
-                       sizeof(struct dmub_cmd_read_modify_write_sequence) * offload->reg_seq_count;
-
-       dc_wake_and_execute_dmub_cmd(ctx, &offload->cmd_data, DM_DMUB_WAIT_TYPE_NO_WAIT);
-
-       memset(cmd_buf, 0, sizeof(*cmd_buf));
-
-       offload->reg_seq_count = 0;
-       offload->same_addr_count = 0;
-}
-
-static inline void submit_dmub_burst_write(
-       struct dc_reg_helper_state *offload,
-       const struct dc_context *ctx)
-{
-       struct dmub_rb_cmd_burst_write *cmd_buf = &offload->cmd_data.burst_write;
-
-       cmd_buf->header.payload_bytes =
-                       sizeof(uint32_t) * offload->reg_seq_count;
-
-       dc_wake_and_execute_dmub_cmd(ctx, &offload->cmd_data, DM_DMUB_WAIT_TYPE_NO_WAIT);
-
-       memset(cmd_buf, 0, sizeof(*cmd_buf));
-
-       offload->reg_seq_count = 0;
-}
-
-static inline void submit_dmub_reg_wait(
-               struct dc_reg_helper_state *offload,
-               const struct dc_context *ctx)
-{
-       struct dmub_rb_cmd_reg_wait *cmd_buf = &offload->cmd_data.reg_wait;
-
-       dc_wake_and_execute_dmub_cmd(ctx, &offload->cmd_data, DM_DMUB_WAIT_TYPE_NO_WAIT);
-
-       memset(cmd_buf, 0, sizeof(*cmd_buf));
-       offload->reg_seq_count = 0;
-}
-
 struct dc_reg_value_masks {
        uint32_t value;
        uint32_t mask;
@@ -127,98 +80,6 @@ static void set_reg_field_values(struct dc_reg_value_masks *field_value_mask,
        }
 }
 
-static void dmub_flush_buffer_execute(
-               struct dc_reg_helper_state *offload,
-               const struct dc_context *ctx)
-{
-       submit_dmub_read_modify_write(offload, ctx);
-}
-
-static void dmub_flush_burst_write_buffer_execute(
-               struct dc_reg_helper_state *offload,
-               const struct dc_context *ctx)
-{
-       submit_dmub_burst_write(offload, ctx);
-}
-
-static bool dmub_reg_value_burst_set_pack(const struct dc_context *ctx, uint32_t addr,
-               uint32_t reg_val)
-{
-       struct dc_reg_helper_state *offload = &ctx->dmub_srv->reg_helper_offload;
-       struct dmub_rb_cmd_burst_write *cmd_buf = &offload->cmd_data.burst_write;
-
-       /* flush command if buffer is full */
-       if (offload->reg_seq_count == DMUB_BURST_WRITE_VALUES__MAX)
-               dmub_flush_burst_write_buffer_execute(offload, ctx);
-
-       if (offload->cmd_data.cmd_common.header.type == DMUB_CMD__REG_SEQ_BURST_WRITE &&
-                       addr != cmd_buf->addr) {
-               dmub_flush_burst_write_buffer_execute(offload, ctx);
-               return false;
-       }
-
-       cmd_buf->header.type = DMUB_CMD__REG_SEQ_BURST_WRITE;
-       cmd_buf->header.sub_type = 0;
-       cmd_buf->addr = addr;
-       cmd_buf->write_values[offload->reg_seq_count] = reg_val;
-       offload->reg_seq_count++;
-
-       return true;
-}
-
-static uint32_t dmub_reg_value_pack(const struct dc_context *ctx, uint32_t addr,
-               struct dc_reg_value_masks *field_value_mask)
-{
-       struct dc_reg_helper_state *offload = &ctx->dmub_srv->reg_helper_offload;
-       struct dmub_rb_cmd_read_modify_write *cmd_buf = &offload->cmd_data.read_modify_write;
-       struct dmub_cmd_read_modify_write_sequence *seq;
-
-       /* flush command if buffer is full */
-       if (offload->cmd_data.cmd_common.header.type != DMUB_CMD__REG_SEQ_BURST_WRITE &&
-                       offload->reg_seq_count == DMUB_READ_MODIFY_WRITE_SEQ__MAX)
-               dmub_flush_buffer_execute(offload, ctx);
-
-       if (offload->should_burst_write) {
-               if (dmub_reg_value_burst_set_pack(ctx, addr, field_value_mask->value))
-                       return field_value_mask->value;
-               else
-                       offload->should_burst_write = false;
-       }
-
-       /* pack commands */
-       cmd_buf->header.type = DMUB_CMD__REG_SEQ_READ_MODIFY_WRITE;
-       cmd_buf->header.sub_type = 0;
-       seq = &cmd_buf->seq[offload->reg_seq_count];
-
-       if (offload->reg_seq_count) {
-               if (cmd_buf->seq[offload->reg_seq_count - 1].addr == addr)
-                       offload->same_addr_count++;
-               else
-                       offload->same_addr_count = 0;
-       }
-
-       seq->addr = addr;
-       seq->modify_mask = field_value_mask->mask;
-       seq->modify_value = field_value_mask->value;
-       offload->reg_seq_count++;
-
-       return field_value_mask->value;
-}
-
-static void dmub_reg_wait_done_pack(const struct dc_context *ctx, uint32_t addr,
-               uint32_t mask, uint32_t shift, uint32_t condition_value, uint32_t time_out_us)
-{
-       struct dc_reg_helper_state *offload = &ctx->dmub_srv->reg_helper_offload;
-       struct dmub_rb_cmd_reg_wait *cmd_buf = &offload->cmd_data.reg_wait;
-
-       cmd_buf->header.type = DMUB_CMD__REG_REG_WAIT;
-       cmd_buf->header.sub_type = 0;
-       cmd_buf->reg_wait.addr = addr;
-       cmd_buf->reg_wait.condition_field_value = mask & (condition_value << shift);
-       cmd_buf->reg_wait.mask = mask;
-       cmd_buf->reg_wait.time_out_us = time_out_us;
-}
-
 uint32_t generic_reg_update_ex(const struct dc_context *ctx,
                uint32_t addr, int n,
                uint8_t shift1, uint32_t mask1, uint32_t field_value1,
@@ -235,11 +96,6 @@ uint32_t generic_reg_update_ex(const struct dc_context *ctx,
 
        va_end(ap);
 
-       if (ctx->dmub_srv &&
-           ctx->dmub_srv->reg_helper_offload.gather_in_progress)
-               return dmub_reg_value_pack(ctx, addr, &field_value_mask);
-               /* todo: return void so we can decouple code running in driver from register states */
-
        /* mmio write directly */
        reg_val = dm_read_reg(ctx, addr);
        reg_val = (reg_val & ~field_value_mask.mask) | field_value_mask.value;
@@ -265,12 +121,6 @@ uint32_t generic_reg_set_ex(const struct dc_context *ctx,
        /* mmio write directly */
        reg_val = (reg_val & ~field_value_mask.mask) | field_value_mask.value;
 
-       if (ctx->dmub_srv &&
-           ctx->dmub_srv->reg_helper_offload.gather_in_progress) {
-               return dmub_reg_value_burst_set_pack(ctx, addr, reg_val);
-               /* todo: return void so we can decouple code running in driver from register states */
-       }
-
        dm_write_reg(ctx, addr, reg_val);
        return reg_val;
 }
@@ -434,13 +284,6 @@ void generic_reg_wait(const struct dc_context *ctx,
        uint32_t reg_val;
        unsigned int i;
 
-       if (ctx->dmub_srv &&
-           ctx->dmub_srv->reg_helper_offload.gather_in_progress) {
-               dmub_reg_wait_done_pack(ctx, addr, mask, shift, condition_value,
-                               delay_between_poll_us * time_out_num_tries);
-               return;
-       }
-
        /*
         * Something is terribly wrong if time out is > 3000ms.
         * 3000ms is the maximum time needed for SMU to pass values back.
@@ -491,12 +334,6 @@ uint32_t generic_read_indirect_reg(const struct dc_context *ctx,
 {
        uint32_t value = 0;
 
-       // when reg read, there should not be any offload.
-       if (ctx->dmub_srv &&
-           ctx->dmub_srv->reg_helper_offload.gather_in_progress) {
-               ASSERT(false);
-       }
-
        dm_write_reg(ctx, addr_index, index);
        value = dm_read_reg(ctx, addr_data);
 
@@ -624,69 +461,6 @@ uint32_t generic_indirect_reg_get_sync(const struct dc_context *ctx,
        return value;
 }
 
-void reg_sequence_start_gather(const struct dc_context *ctx)
-{
-       /* if reg sequence is supported and enabled, set flag to
-        * indicate we want to have REG_SET, REG_UPDATE macro build
-        * reg sequence command buffer rather than MMIO directly.
-        */
-
-       if (ctx->dmub_srv && ctx->dc->debug.dmub_offload_enabled) {
-               struct dc_reg_helper_state *offload =
-                       &ctx->dmub_srv->reg_helper_offload;
-
-               /* caller sequence mismatch.  need to debug caller.  offload will not work!!! */
-               ASSERT(!offload->gather_in_progress);
-
-               offload->gather_in_progress = true;
-       }
-}
-
-void reg_sequence_start_execute(const struct dc_context *ctx)
-{
-       struct dc_reg_helper_state *offload;
-
-       if (!ctx->dmub_srv)
-               return;
-
-       offload = &ctx->dmub_srv->reg_helper_offload;
-
-       if (offload && offload->gather_in_progress) {
-               offload->gather_in_progress = false;
-               offload->should_burst_write = false;
-               switch (offload->cmd_data.cmd_common.header.type) {
-               case DMUB_CMD__REG_SEQ_READ_MODIFY_WRITE:
-                       submit_dmub_read_modify_write(offload, ctx);
-                       break;
-               case DMUB_CMD__REG_REG_WAIT:
-                       submit_dmub_reg_wait(offload, ctx);
-                       break;
-               case DMUB_CMD__REG_SEQ_BURST_WRITE:
-                       submit_dmub_burst_write(offload, ctx);
-                       break;
-               default:
-                       return;
-               }
-       }
-}
-
-void reg_sequence_wait_done(const struct dc_context *ctx)
-{
-       /* callback to DM to poll for last submission done*/
-       struct dc_reg_helper_state *offload;
-
-       if (!ctx->dmub_srv)
-               return;
-
-       offload = &ctx->dmub_srv->reg_helper_offload;
-
-       if (offload &&
-           ctx->dc->debug.dmub_offload_enabled &&
-           !ctx->dc->debug.dmcub_emulation) {
-               dc_dmub_srv_wait_for_idle(ctx->dmub_srv, DM_DMUB_WAIT_TYPE_WAIT, NULL);
-       }
-}
-
 char *dce_version_to_string(const int version)
 {
        switch (version) {
index 8b062b011fc65ab915e6cd7308e4f80d5649e6c8..2cf4bcb03cb06bd08e989aa2440967f633450d1e 100644 (file)
@@ -127,10 +127,6 @@ uint32_t generic_reg_update_ex(const struct dc_context *ctx,
 struct dc_dmub_srv *dc_dmub_srv_create(struct dc *dc, struct dmub_srv *dmub);
 void dc_dmub_srv_destroy(struct dc_dmub_srv **dmub_srv);
 
-void reg_sequence_start_gather(const struct dc_context *ctx);
-void reg_sequence_start_execute(const struct dc_context *ctx);
-void reg_sequence_wait_done(const struct dc_context *ctx);
-
 #define FD(reg_field)  reg_field ## __SHIFT, \
                                                reg_field ## _MASK
 
index 53b21adc6267d3aac7a8dfd32edec2bff8297012..9788628cf0ad1074fa8ea6c046129cf3f265804c 100644 (file)
@@ -397,8 +397,6 @@ void dpp1_cm_program_regamma_lut(struct dpp *dpp_base,
        uint32_t i;
        struct dcn10_dpp *dpp = TO_DCN10_DPP(dpp_base);
 
-       REG_SEQ_START();
-
        for (i = 0 ; i < num; i++) {
                REG_SET(CM_RGAM_LUT_DATA, 0, CM_RGAM_LUT_DATA, rgb[i].red_reg);
                REG_SET(CM_RGAM_LUT_DATA, 0, CM_RGAM_LUT_DATA, rgb[i].green_reg);
@@ -408,9 +406,6 @@ void dpp1_cm_program_regamma_lut(struct dpp *dpp_base,
                REG_SET(CM_RGAM_LUT_DATA, 0, CM_RGAM_LUT_DATA, rgb[i].delta_green_reg);
                REG_SET(CM_RGAM_LUT_DATA, 0, CM_RGAM_LUT_DATA, rgb[i].delta_blue_reg);
        }
-
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
 }
 
 void dpp1_cm_configure_regamma_lut(
index 8f9038fec0f7ba690810b8f255351ad22c3f71bf..01027d120cb04319709d73fab5f8984ec540c4f1 100644 (file)
@@ -581,9 +581,6 @@ void dcn35_power_down_on_boot(struct dc *dc)
 
 bool dcn35_apply_idle_power_optimizations(struct dc *dc, bool enable)
 {
-       if (dc->debug.dmcub_emulation)
-               return true;
-
        if (enable) {
                uint32_t num_active_edp = 0;
                int i;
index 7a1ecb8d986f2284a2cbe2f2b33e0830aeeafa13..6d15ccdc7f878743b835b9874eb6d3bf079e6ab4 100644 (file)
@@ -536,23 +536,4 @@ uint32_t generic_indirect_reg_update_ex_sync(const struct dc_context *ctx,
                uint8_t shift1, uint32_t mask1, uint32_t field_value1,
                ...);
 
-/* register offload macros
- *
- * instead of MMIO to register directly, in some cases we want
- * to gather register sequence and execute the register sequence
- * from another thread so we optimize time required for lengthy ops
- */
-
-/* start gathering register sequence */
-#define REG_SEQ_START() \
-       reg_sequence_start_gather(CTX)
-
-/* start execution of register sequence gathered since REG_SEQ_START */
-#define REG_SEQ_SUBMIT() \
-       reg_sequence_start_execute(CTX)
-
-/* wait for the last REG_SEQ_SUBMIT to finish */
-#define REG_SEQ_WAIT_DONE() \
-       reg_sequence_wait_done(CTX)
-
 #endif /* DRIVERS_GPU_DRM_AMD_DC_DEV_DC_INC_REG_HELPER_H_ */
index fa600593f4c1627e454cfed5a5ea7ba322ec76cf..0e09d073ab292460f7b9154c759b1a6b52609649 100644 (file)
@@ -380,7 +380,6 @@ static void mpc20_program_ogam_pwl(
        struct dcn20_mpc *mpc20 = TO_DCN20_MPC(mpc);
 
        PERF_TRACE();
-       REG_SEQ_START();
 
        for (i = 0 ; i < num; i++) {
                REG_SET(MPCC_OGAM_LUT_DATA[mpcc_id], 0, MPCC_OGAM_LUT_DATA, rgb[i].red_reg);
@@ -395,9 +394,6 @@ static void mpc20_program_ogam_pwl(
                                MPCC_OGAM_LUT_DATA, rgb[i].delta_blue_reg);
        }
 
-       REG_SEQ_SUBMIT();
-       PERF_TRACE();
-       REG_SEQ_WAIT_DONE();
        PERF_TRACE();
 }
 
index e6426ccee2d88affb204551d8647798113fc9e36..cf8e22289d6aea0c7a39e050c606f60e590d2f63 100644 (file)
@@ -539,16 +539,11 @@ static bool optc1_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 3,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index c558b1d633f32bbb161e1671478e93dd4000924e..73cc8a713556b16888d378eb0102cd293235ce9b 100644 (file)
@@ -63,16 +63,11 @@ bool optc2_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 3,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index 98aaa22ce81cf7f93a17b46fe1f0d6dc2becdf2f..3ace83e1b50f0d00056d318e70f2688cbd1d88df 100644 (file)
@@ -105,16 +105,11 @@ static bool optc31_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 2,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index a7cf34937b2f8d6af9e86aa279400f61da059e9b..7250478a50925a1f24f527090f5994855842ece4 100644 (file)
@@ -115,16 +115,11 @@ static bool optc314_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 2,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index 07895d5f4dfa07e28c36c51bf5fe9af963d0d89b..f9e05efcad98806b455ae7793b0797a304a8d20a 100644 (file)
@@ -155,16 +155,11 @@ static bool optc32_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 2,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index 62f45c156c32590df1dfdb42858c54b6fa7e6ed9..9b7f9d5bbfb38d321d48faabe220743307a04f99 100644 (file)
@@ -122,16 +122,11 @@ static bool optc35_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 2,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index a6d76f451cf8c0d5d36d13a1e46118cbf760bbc2..5fcdd74eb4a03f916b5b5b91350bbbe1b6abfd98 100644 (file)
@@ -189,16 +189,11 @@ bool optc401_enable_crtc(struct timing_generator *optc)
        REG_UPDATE(CONTROL,
                        VTG0_ENABLE, 1);
 
-       REG_SEQ_START();
-
        /* Enable CRTC */
        REG_UPDATE_2(OTG_CONTROL,
                        OTG_DISABLE_POINT_CNTL, 2,
                        OTG_MASTER_EN, 1);
 
-       REG_SEQ_SUBMIT();
-       REG_SEQ_WAIT_DONE();
-
        return true;
 }
 
index 53596e790eb4e3abfd720a44236d41cd1027718b..a5ed62db1de8b65f848111903eb0bf55c96f3b79 100644 (file)
@@ -819,7 +819,6 @@ static const struct dc_debug_options debug_defaults_drv = {
        .enable_hpo_pg_support = false,
        .enable_single_display_2to1_odm_policy = true,
        .disable_idle_power_optimizations = false,
-       .dmcub_emulation = false,
        .disable_boot_optimizations = false,
        .disable_unbounded_requesting = false,
        .disable_mem_low_power = false,
index 3e2c9cfd555dee0e9ecb4326a5535500b768dd56..9c1d65c2d4aba43500ec0047eff88193b46490ae 100644 (file)
@@ -799,7 +799,6 @@ static const struct dc_debug_options debug_defaults_drv = {
        .enable_hpo_pg_support = false,
        .enable_single_display_2to1_odm_policy = true,
        .disable_idle_power_optimizations = false,
-       .dmcub_emulation = false,
        .disable_boot_optimizations = false,
        .disable_unbounded_requesting = false,
        .disable_mem_low_power = false,
index 9e795130eb8972a052dc11fe847df6dd48aaa6a0..8041e035f22671d0a9cda95ebbd9c154977090ab 100644 (file)
@@ -806,7 +806,6 @@ static const struct dc_debug_options debug_defaults_drv = {
        .enable_hpo_pg_support = false,
        .enable_single_display_2to1_odm_policy = true,
        .disable_idle_power_optimizations = false,
-       .dmcub_emulation = false,
        .disable_boot_optimizations = false,
        .disable_unbounded_requesting = false,
        .disable_mem_low_power = false,