]> git.hungrycats.org Git - linux/commitdiff
kbuild: fix broken kallsyms on non-x86 archs
authorKai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Thu, 16 Jan 2003 03:58:00 +0000 (21:58 -0600)
committerLinus Torvalds <torvalds@home.transmeta.com>
Thu, 16 Jan 2003 03:58:00 +0000 (21:58 -0600)
From: James Bottomley <James.Bottomley@steeleye.com>

kallsyms is broken in parisc on 2.5.56 again because of assembler syntax
subtleties.  This is the offending line:

printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n"

Note the `;' separating the two statements.  On some platforms `;' is a
comment in assembly code, and thus the following .asciz is ignored.

scripts/kallsyms.c

index 317975123b18df64a8d2bf328de20f8143c1a5de..25ce910dcf757d9947dc0be40a221a2f1f460563 100644 (file)
@@ -144,7 +144,7 @@ write_src(void)
                for (k = 0; table[i].sym[k] && table[i].sym[k] == prev[k]; ++k)
                        ; 
 
-               printf("\t.byte 0x%02x ; .asciz\t\"%s\"\n", k, table[i].sym + k);
+               printf("\t.byte 0x%02x\n\t.asciz\t\"%s\"\n", k, table[i].sym + k);
                last_addr = table[i].addr;
                prev = table[i].sym;
        }