]> git.hungrycats.org Git - linux/commitdiff
ovl: fix workdir creation
authorMiklos Szeredi <mszeredi@redhat.com>
Mon, 5 Sep 2016 11:55:20 +0000 (13:55 +0200)
committerSasha Levin <alexander.levin@verizon.com>
Sun, 2 Oct 2016 23:12:05 +0000 (19:12 -0400)
[ Upstream commit e1ff3dd1ae52cef5b5373c8cc4ad949c2c25a71c ]

Workdir creation fails in latest kernel.

Fix by allowing EOPNOTSUPP as a valid return value from
vfs_removexattr(XATTR_NAME_POSIX_ACL_*).  Upper filesystem may not support
ACL and still be perfectly able to support overlayfs.

Reported-by: Martin Ziegler <ziegler@uni-freiburg.de>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: c11b9fdd6a61 ("ovl: remove posix_acl_default from workdir")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
fs/overlayfs/super.c

index c9b740111526547424ba816cf8d8be4885bdc11a..f60b2c745d023c5a9d1f47b4f5d5d7ccc506f0d6 100644 (file)
@@ -679,11 +679,11 @@ retry:
                        goto out_dput;
 
                err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_DEFAULT);
-               if (err && err != -ENODATA)
+               if (err && err != -ENODATA && err != -EOPNOTSUPP)
                        goto out_dput;
 
                err = vfs_removexattr(work, XATTR_NAME_POSIX_ACL_ACCESS);
-               if (err && err != -ENODATA)
+               if (err && err != -ENODATA && err != -EOPNOTSUPP)
                        goto out_dput;
 
                /* Clear any inherited mode bits */