[PATCH] logic error in aty128fb

Negate the expression not the register seems more sensible?

diff --git a/drivers/video/aty/aty128fb.c b/drivers/video/aty/aty128fb.c
index 2b728ed4ab94d354668873bdf969ecca32b75c27..781c4613e9a4f2f738fc071c61514defe5a842ec 100644 (file)
--- a/drivers/video/aty/aty128fb.c
+++ b/drivers/video/aty/aty128fb.c
@@ -2102,7 +2102,7 @@ aty128_set_backlight_enable(int on, int level, void *data)
        reg |= LVDS_BL_MOD_EN | LVDS_BLON;
        if (on && level > BACKLIGHT_OFF) {
                reg |= LVDS_DIGION;
-               if (!reg & LVDS_ON) {
+               if (!(reg & LVDS_ON)) {
                        reg &= ~LVDS_BLON;
                        aty_st_le32(LVDS_GEN_CNTL, reg);
                        (void)aty_ld_le32(LVDS_GEN_CNTL);