]> git.hungrycats.org Git - linux/commitdiff
regulator: qcom_smd: Remove list_voltage callback for rpm_smps_ldo_ops_fixed
authorAxel Lin <axel.lin@ingics.com>
Wed, 15 Jun 2016 02:21:34 +0000 (10:21 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Aug 2016 07:33:17 +0000 (09:33 +0200)
commit 43160ffd12c8d1d331362362eea3c70e04b6f9c4 upstream.

Use regulator_list_voltage_linear_range in rpm_smps_ldo_ops_fixed is
wrong because it is used for fixed regulator without any linear range.
The rpm_smps_ldo_ops_fixed is used for pm8941_lnldo which has fixed_uV
set and n_voltages = 1. In this case, regulator_list_voltage() can return
rdev->desc->fixed_uV without .list_voltage implementation.

Fixes: 3bfbb4d1a480 ("regulator: qcom_smd: add list_voltage callback")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/regulator/qcom_smd-regulator.c

index 6c7fe4778793758478d9a27e3f9d11f6d4b4a1b2..7e156a0b65dd9a22c7e57ccf6a299ceee3de3e66 100644 (file)
@@ -140,7 +140,6 @@ static const struct regulator_ops rpm_smps_ldo_ops = {
        .enable = rpm_reg_enable,
        .disable = rpm_reg_disable,
        .is_enabled = rpm_reg_is_enabled,
-       .list_voltage = regulator_list_voltage_linear_range,
 
        .get_voltage = rpm_reg_get_voltage,
        .set_voltage = rpm_reg_set_voltage,