pstore: Fix leaked pstore_record in pstore_get_backend_records()

commit f6525b96dd9f68efe374e5aef864975e628de991 upstream.

When the "if (record->size <= 0)" test is true in
pstore_get_backend_records() it's pretty clear that nobody holds a
reference to the allocated pstore_record, yet we don't free it.

Let's free it.

Fixes: 2a2b0acf768c ("pstore: Allocate records on heap instead of stack")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/pstore/platform.c b/fs/pstore/platform.c
index d468eec9b8a6ba9aa574055c0e76c615e2ede9d0..9defe98ff8b1c5d48555f553d1560a97579cf3c4 100644 (file)
--- a/fs/pstore/platform.c
+++ b/fs/pstore/platform.c
@@ -846,8 +846,10 @@ void pstore_get_backend_records(struct pstore_info *psi,
                record->size = psi->read(record);
 
                /* No more records left in backend? */
-               if (record->size <= 0)
+               if (record->size <= 0) {
+                       kfree(record);
                        break;
+               }
 
                decompress_record(record);
                rc = pstore_mkfile(root, record);