net: mac802154: Fix racy device stats updates by DEV_STATS_INC() and DEV_STATS_ADD()

[ Upstream commit b8ec0dc3845f6c9089573cb5c2c4b05f7fc10728 ]

mac802154 devices update their dev->stats fields locklessly. Therefore
these counters should be updated atomically. Adopt SMP safe DEV_STATS_INC()
and DEV_STATS_ADD() to achieve this.

Signed-off-by: Yunshui Jiang <jiangyunshui@kylinos.cn>
Message-ID: <20240531080739.2608969-1-jiangyunshui@kylinos.cn>
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/net/mac802154/tx.c b/net/mac802154/tx.c
index 2a6f1ed763c9bded3913a8e5ce0c46bd486ebab6..6fbed5bb5c3e0d5f838c92c8ad50494814982d34 100644 (file)
--- a/net/mac802154/tx.c
+++ b/net/mac802154/tx.c
@@ -34,8 +34,8 @@ void ieee802154_xmit_sync_worker(struct work_struct *work)
        if (res)
                goto err_tx;
 
-       dev->stats.tx_packets++;
-       dev->stats.tx_bytes += skb->len;
+       DEV_STATS_INC(dev, tx_packets);
+       DEV_STATS_ADD(dev, tx_bytes, skb->len);
 
        ieee802154_xmit_complete(&local->hw, skb, false);
 
@@ -90,8 +90,8 @@ ieee802154_tx(struct ieee802154_local *local, struct sk_buff *skb)
                if (ret)
                        goto err_wake_netif_queue;
 
-               dev->stats.tx_packets++;
-               dev->stats.tx_bytes += len;
+               DEV_STATS_INC(dev, tx_packets);
+               DEV_STATS_ADD(dev, tx_bytes, len);
        } else {
                local->tx_skb = skb;
                queue_work(local->workqueue, &local->sync_tx_work);