]> git.hungrycats.org Git - linux/commitdiff
ip_tunnel_core: Change __skb_push back to skb_push
authorSteffen Klassert <steffen.klassert@secunet.com>
Tue, 1 Oct 2013 09:35:51 +0000 (11:35 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 14 Oct 2013 01:14:26 +0000 (18:14 -0700)
[ Upstream commit 78a3694d44a029242dd0830b34ab20ef1704be35 ]

Git commit 0e6fbc5b ("ip_tunnels: extend iptunnel_xmit()")
moved the IP header installation to iptunnel_xmit() and
changed skb_push() to __skb_push(). This makes possible
bugs hard to track down, so change it back to skb_push().

Cc: Pravin Shelar <pshelar@nicira.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/ip_tunnel_core.c

index 850525b34899f3a50d0e19f6bd326821b0c2423a..3fbba1753f2c69b3da9ae600ffb45b58e0616071 100644 (file)
@@ -63,7 +63,7 @@ int iptunnel_xmit(struct net *net, struct rtable *rt,
        memset(IPCB(skb), 0, sizeof(*IPCB(skb)));
 
        /* Push down and install the IP header. */
-       __skb_push(skb, sizeof(struct iphdr));
+       skb_push(skb, sizeof(struct iphdr));
        skb_reset_network_header(skb);
 
        iph = ip_hdr(skb);